New CmdLet to get UsageAggregates by Matt-Westphal · Pull Request #517 · Azure/azure-powershell

Matt-Westphal · 2015-06-18T19:31:53Z

This command will get the usage data for a subscription.

Also added a script to verify the module works as expected

The test is marked as skipped since I can get the test framework to start after working at it for 4 days.

azurecla · 2015-06-18T19:31:58Z

Hi @Matt-Westphal, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

markcowl · 2015-06-19T20:42:29Z

src/ResourceManager/Commerce/Commands.UsageAggregates/TestTheCmdLet.ps1

Please do not check in files with hardcoded paths

markcowl · 2015-06-19T20:46:34Z

This PR should also include: (1) Updated installer that includes your files (use the BuildInstaller script in the Tools folder); (2) dll help file; (3) Changes to changelog.txt describing your new cmdlet

markcowl · 2015-06-19T20:47:59Z

src/ResourceManager/Commerce/Commands.UsageAggregates/GetUsageAggregatesCommand.cs

Why ReportedStartTime and ReportedEndTime and not just StartTime and EndTime?

With usage data there is multiple uses of DateTime. Reported vs when the usage was consumed. which is a critical distinction to make sure they consumers have all the data they need. Also this is consistent with output of the billing data from the Azure system

markcowl · 2015-06-19T20:54:04Z

@azuresdkci retest this please

Matt-Westphal · 2015-06-19T21:32:14Z

Where can I find some documentation or any idea where/how to do these? Would have included them if I had known they needed to be done.

From: Mark Cowlishaw [mailto:notifications@github.com]
Sent: Friday, June 19, 2015 1:47 PM
To: Azure/azure-powershell
Cc: Matt Westphal
Subject: Re: [azure-powershell] New CmdLet to get UsageAggregates (#517)

This PR should also include: (1) Updated installer that includes your files (use the BuildInstaller script in the Tools folder); (2) dll help file; (3) Changes to changelog.txt describing your new cmdlet

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/517#issuecomment-113638458.

…fore committing

hovsepm · 2015-06-20T00:59:30Z

please pull from upstream and resolve conflicts.

New CmdLet to get UsageAggregates

pmsousa · 2015-09-11T16:20:00Z

Hi,
I think I might have found a bug. When calling the cmdlet Get-UsageAggregates I get a error message:

Get-UsageAggregates -ReportedStartTime "2015-08-20" -ReportedEndTime "2015-08-21" -Debug

Get-UsageAggregates : The request is invalid.
At line:1 char:1
+ Get-UsageAggregates -ReportedStartTime "2015-08-20" -ReportedEndTime  ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : CloseError: (:) [Get-UsageAggregates], CloudException
    + FullyQualifiedErrorId : Microsoft.Azure.Commands.UsageAggregates.GetUsageAggregatesCommand

I thought the problem could have been with the date format,so I've tried several different ways: dd/mm/yyyy, yyyy/mm/dd, etc. Always the same result.

Finally, I've used the -debug flag and these were my findings:

DEBUG: [Common.Authentication]: Checking token expiration, token expires '09/11/2015 16:00:27 +00:00' Comparing to '09/11/2015 15:04:10 +00:
00' With threshold '00:05:00', calculated time until token expiry: '00:56:16.8425779'
DEBUG: ============================ HTTP REQUEST ============================

HTTP Method:
GET

Absolute Uri:
https://management.azure.com/subscriptions/{SUBSCRIPTIONID}/providers/Microsoft.Commerce/UsageAggregates?api-version=201
5-06-01-preview&reportedstartTime=20%2F08%2F2015 00:00:00&reportedEndTime=21%2F08%2F2015 00:00:00,&showDetails=true&aggregationGranularity=D
aily

Headers:

Body:



DEBUG: ============================ HTTP RESPONSE ============================

Status Code:
BadRequest

Headers:
Pragma                        : no-cache
x-ms-ratelimit-remaining-subscription-reads: 14998
x-ms-request-id               : e5e62bf5-d2a3-4604-aa59-23652c33613c
x-ms-correlation-request-id   : e5e62bf5-d2a3-4604-aa59-23652c33613c
x-ms-routing-request-id       : NORTHEUROPE:20150911T150411Z:e5e62bf5-d2a3-4604-aa59-23652c33613c
Strict-Transport-Security     : max-age=31536000; includeSubDomains
Cache-Control                 : no-cache
Date                          : Fri, 11 Sep 2015 15:04:11 GMT
Server                        : Microsoft-IIS/8.0
X-AspNet-Version              : 4.0.30319
X-Powered-By                  : ASP.NET

Body:
{
  "message": "The request is invalid."
}

If you note the URI, the reportedstartTime and reportedEndTime fields have spaces between the date and time; I think theses should be URL Encoded or set to ShortDate format!

PS: I've replaced my subscription ID with the text {SUBSCRIPTIONID}

HPF PR: dev <- Azure:dev

Matt-Westphal added 13 commits June 15, 2015 15:42

added project shell

0e28a0d

added test project

bc68a15

adding appropriate nuget packages

0f7274e

Added enough code to build with the commerce package

db2f4e6

working on tests

265c244

trying to get this to build and show the tests

77f3a51

everything compiles, now to get the test to work

526ee38

got to compile with xUnit and show the tests

386d598

small mods

eb4f8d2

minor updates, skipping the tests for now

d8d9326

re adding tests

2e1f65b

trying out different way to call the powershell

bc0c76a

adding script to import and test the new UsageAggregates module

f54875c

azurecla added the cla-required label Jun 18, 2015

Matt-Westphal added 7 commits June 18, 2015 13:30

csproj was referencing a file that didn't exist

fa2ba22

got the tests to run

0f9bc58

remove unused files

f982719

removed app.config

4b7b931

added our tests to the powershell test tagets

e084368

added another place for the targets file

9f9e6bc

updated name of dll for the test project to align with others

11a805b

markcowl reviewed Jun 19, 2015
View reviewed changes

src/ResourceManager/Commerce/Commands.UsageAggregates/TestTheCmdLet.ps1 Outdated

Copy link

Member

markcowl Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not check in files with hardcoded paths

markcowl reviewed Jun 19, 2015
View reviewed changes

Updated code based on pull request feedback

2bf9e8e

Matt-Westphal and others added 6 commits June 19, 2015 14:45

added Get-usageaggregates to changelog.txt

a1f7e78

added UsageAggregates to the installer

bf82141

fixed csproj, was using wrong filename for help. didn't click save be…

0ec0008

…fore committing

updated help file correctly for Get-UsageAggregates

db579db

Edit help file.

66f51fa

updated help file with formatting from help editor

e6554d9

Matt-Westphal added 2 commits June 19, 2015 18:26

pulled from Azure repo and up

b089637

fixed merge error

5880776

hovsepm pushed a commit that referenced this pull request Jun 20, 2015

Merge pull request #517 from Matt-Westphal/dev

bd685f0

New CmdLet to get UsageAggregates

hovsepm merged commit bd685f0 into Azure:dev Jun 20, 2015

huangpf added a commit to AzureRT/azure-powershell that referenced this pull request Apr 28, 2016

Merge pull request Azure#517 from Azure/dev

b831d40

HPF PR: dev <- Azure:dev

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

New CmdLet to get UsageAggregates#517

New CmdLet to get UsageAggregates#517
hovsepm merged 29 commits intoAzure:devfrom
Matt-Westphal:dev

Matt-Westphal commented Jun 18, 2015

Uh oh!

azurecla commented Jun 18, 2015

Uh oh!

markcowl Jun 19, 2015

Uh oh!

markcowl commented Jun 19, 2015

Uh oh!

markcowl Jun 19, 2015

Uh oh!

Matt-Westphal Jun 19, 2015

Uh oh!

markcowl commented Jun 19, 2015

Uh oh!

Matt-Westphal commented Jun 19, 2015

Uh oh!

hovsepm commented Jun 20, 2015

Uh oh!

pmsousa commented Sep 11, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

Conversation

Matt-Westphal commented Jun 18, 2015

Uh oh!

azurecla commented Jun 18, 2015

Uh oh!

markcowl Jun 19, 2015

Choose a reason for hiding this comment

Uh oh!

markcowl commented Jun 19, 2015

Uh oh!

markcowl Jun 19, 2015

Choose a reason for hiding this comment

Uh oh!

Matt-Westphal Jun 19, 2015

Choose a reason for hiding this comment

Uh oh!

markcowl commented Jun 19, 2015

Uh oh!

Matt-Westphal commented Jun 19, 2015

Uh oh!

hovsepm commented Jun 20, 2015

Uh oh!

pmsousa commented Sep 11, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants